From a273e90b445ec82a04f92187adfe610cd0703dba Mon Sep 17 00:00:00 2001 From: David Vazgenovich Shakaryan Date: Tue, 26 Apr 2022 23:29:00 -0700 Subject: web: rid HTML of inline JS Maybe I'll change this to use targeted event listeners when I'm not lazy. --- web/dartboat_wasm.c | 24 ++++++++++++------------ web/static/dartboat.js | 27 +++++++++++++++++++++------ web/static/index.html | 40 ++++++++++++++++++++-------------------- 3 files changed, 53 insertions(+), 38 deletions(-) diff --git a/web/dartboat_wasm.c b/web/dartboat_wasm.c index 4c9973b..7c06849 100644 --- a/web/dartboat_wasm.c +++ b/web/dartboat_wasm.c @@ -485,7 +485,7 @@ char *prompt_get() return (char *)EM_ASM_INT({return promptGet()}); } -void prompt_handle_pre(char *action) +void prompt_handle_pre(char *command) { if (pm == PM_NONE) return; @@ -493,13 +493,13 @@ void prompt_handle_pre(char *action) EM_ASM(clearOi()); if ((pm == PM_VISIT || pm == PM_NUM_DARTS || pm == PM_END_MATCH) && - strcmp(action, "undo")) + strcmp(command, "undo")) deactivate_key("undo"); - if (pm == PM_END_MATCH && strcmp(action, "rem")) + if (pm == PM_END_MATCH && strcmp(command, "rem")) deactivate_key("rem"); - if (pm == PM_END_MATCH && strcmp(action, "submit")) + if (pm == PM_END_MATCH && strcmp(command, "submit")) deactivate_key("submit"); } @@ -610,21 +610,21 @@ void prompt_handle_undo() toggle_key("undo"); } -EMSCRIPTEN_KEEPALIVE void prompt_handle(char *action, char *data) +EMSCRIPTEN_KEEPALIVE void prompt_handle(char *command, char *data) { - prompt_handle_pre(action); + prompt_handle_pre(command); - if (!strcmp(action, "append")) + if (!strcmp(command, "append")) prompt_handle_append(data); - else if (!strcmp(action, "backspace")) + else if (!strcmp(command, "backspace")) prompt_handle_backspace(); - else if (!strcmp(action, "clear")) + else if (!strcmp(command, "clear")) prompt_handle_clear(); - else if (!strcmp(action, "submit")) + else if (!strcmp(command, "submit")) prompt_handle_submit(); - else if (!strcmp(action, "rem")) + else if (!strcmp(command, "rem")) prompt_handle_rem(); - else if (!strcmp(action, "undo")) + else if (!strcmp(command, "undo")) prompt_handle_undo(); } diff --git a/web/static/dartboat.js b/web/static/dartboat.js index 428ff85..285a98e 100644 --- a/web/static/dartboat.js +++ b/web/static/dartboat.js @@ -54,8 +54,8 @@ function promptMsgR(p) { document.getElementById('prompt-msg-r').textContent = UTF8ToString(p); } -function promptHandle(action, data) { - Module.ccall('prompt_handle', null, ['string', 'string'], [action, data]); +function promptHandle(command, data) { + Module.ccall('prompt_handle', null, ['string', 'string'], [command, data]); } function setKeypad(keypad) { @@ -169,12 +169,27 @@ function readOpts() { setStdev(val, false); } -function modal(id) { - document.getElementById(id).style.display = 'block'; -} +document.addEventListener('click', e => { + const modal = e.target.dataset.modal; + if (modal) + document.getElementById(modal).style.display = 'block'; + + if (e.target.classList.contains('modal')) + e.target.style.display = 'none'; +}); document.addEventListener('click', e => { - if (e.target.classList.contains('modal')) e.target.style.display = 'none'; + const command = e.target.dataset.command; + if (command) + command.split(';').forEach(x => promptHandle(...x.split(':', 2))); +}); + +document.addEventListener('change', e => { + const setting = e.target.dataset.setting; + if (setting === 'delay') + setDelay(e.target.value); + else if (setting === 'stdev') + setStdev(e.target.value); }); document.addEventListener('keydown', e => { diff --git a/web/static/index.html b/web/static/index.html index 2af1f35..2bc1275 100644 --- a/web/static/index.html +++ b/web/static/index.html @@ -36,32 +36,32 @@
-
[1] Play against bot
-
[2] One-player scoreboard
-
[3] Two-player scoreboard
+
[1] Play against bot
+
[2] One-player scoreboard
+
[3] Two-player scoreboard
dartboat™
-
delay
-
stdev
-
?
+
delay
+
stdev
+
?
-- cgit v1.2.3-70-g09d2